[
https://issues.apache.org/jira/browse/ARCHETYPE-64?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17791784#comment-17791784
]
ASF GitHub Bot commented on ARCHETYPE-64:
-----------------------------------------
WolfgangHG opened a new pull request, #160:
URL: https://github.com/apache/maven-archetype/pull/160
This pull request tries to work around a warning "Don't override file ..."
or "CP Don't override file..." that appeared after switching from maven
archetype plugin 3.1.2 to 3.2.1 - more details and a sample see
https://issues.apache.org/jira/browse/ARCHETYPE-649
The warning seems to be caused by fileset declarations in
"archetype-metadata.xml": with 3.2.1, the archetype jar file contains entries
for all directories, but before there were only entries for the actual files in
the zip. I could also verify this difference by analyzing the jar file with
WinZip.
I could work around the warning by switching off "IncludeEmptyDirs" in two
places in "JarMojo.execute".
My first thought was to pass the paths of the "archetype-metadata.xml"
filesets to the second argument of "DefaultFileSet.includeExclude()", but this
did not have any effect - but this might also be caused by me using wrong
paths;-)
[DISCLAIMER] This is my first pull request to maven, I don't have knowledge
of the internals - just trying to workaround an issue that I run into. Maybe
the problem is also caused by me misusing the filesets in
"archetype-metadata.xml".
So please consider this more a start of a discussion that a "I have fixed
something" statement ;-). If you have better suggestions to resolve this,
please point me to them.
> groupId and version redundant when executing archetype with parent
> ------------------------------------------------------------------
>
> Key: ARCHETYPE-64
> URL: https://issues.apache.org/jira/browse/ARCHETYPE-64
> Project: Maven Archetype
> Issue Type: Improvement
> Components: Generator
> Affects Versions: 1.0-alpha-4
> Reporter: Rod Coffin
> Priority: Major
> Attachments: ARCHETYPE-64-maven-archetype-core.patch
>
>
> Running the archetype plugin in a parent project creates a sub-project
> (module). Although the parent elements are properly set in the child pom,
> the group id and version are repeated. These are not necessary since they
> will be inherited from the parent. Ex:
> {code:xml}
> <parent>
> <artifactId>parent</artifactId>
> <groupId>com.rfc.archetypes.example</groupId>
> <version>1.0-SNAPSHOT</version>
> </parent>
> <modelVersion>4.0.0</modelVersion>
> <groupId>com.rfc.archetypes.example</groupId>
> <artifactId>example-web</artifactId>
> <version>1.0-SNAPSHOT</version>
> {code}
> Having this information is two places is bad in principle because it violates
> the DRY principle and in practice because they can get out of sync
> accidentally and it could be confusing.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
