[ 
https://issues.apache.org/jira/browse/ARCHETYPE-64?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17794390#comment-17794390
 ] 

ASF GitHub Bot commented on ARCHETYPE-64:
-----------------------------------------

WolfgangHG commented on PR #160:
URL: https://github.com/apache/maven-archetype/pull/160#issuecomment-1845931487

   @elharo I attached a full sample project to 
https://issues.apache.org/jira/browse/ARCHETYPE-649. I probably could create a 
smaller sample (web app project instead of ear project with two modules). But 
you request a unit test as part of the archetype build process? How could I 
create such a test project?




> groupId and version redundant when executing archetype with parent
> ------------------------------------------------------------------
>
>                 Key: ARCHETYPE-64
>                 URL: https://issues.apache.org/jira/browse/ARCHETYPE-64
>             Project: Maven Archetype
>          Issue Type: Improvement
>          Components: Generator
>    Affects Versions: 1.0-alpha-4
>            Reporter: Rod Coffin
>            Priority: Major
>         Attachments: ARCHETYPE-64-maven-archetype-core.patch
>
>
> Running the archetype plugin in a parent project creates a sub-project 
> (module).  Although the parent elements are properly set in the child pom, 
> the group id and version are repeated.  These are not necessary since they 
> will be inherited from the parent.  Ex:
> {code:xml}
>   <parent>
>     <artifactId>parent</artifactId>
>     <groupId>com.rfc.archetypes.example</groupId>
>     <version>1.0-SNAPSHOT</version>
>   </parent>
>   <modelVersion>4.0.0</modelVersion>
>   <groupId>com.rfc.archetypes.example</groupId>
>   <artifactId>example-web</artifactId>
>   <version>1.0-SNAPSHOT</version>
> {code}
> Having this information is two places is bad in principle because it violates 
> the DRY principle and in practice because they can get out of sync 
> accidentally and it could be confusing.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to