elharo commented on code in PR #1064:
URL: https://github.com/apache/maven/pull/1064#discussion_r1144677160
##########
maven-core/src/test/java/org/apache/maven/repository/TestRepositorySystem.java:
##########
@@ -229,7 +229,7 @@ public ArtifactResolutionResult
resolve(ArtifactResolutionRequest request) {
.map(Dependency::new)
.collect(Collectors.toList());
} catch (IOException e) {
- e.printStackTrace();
Review Comment:
Given that this is test code, debug logging seems too weak. If this is a
problem worth paying attention to, or that might explain why a test has failed
or flaked, then bubble the IOException to immediately fail the test with the
root cause rather than waiting for it to fail down the line.
On the other hand, if the test shouldn't and doesn't fail when this
exception is thrown, then no debug log is needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
