elharo commented on code in PR #1064:
URL: https://github.com/apache/maven/pull/1064#discussion_r1144672706
##########
maven-core/src/main/java/org/apache/maven/toolchain/RequirementMatcherFactory.java:
##########
@@ -73,8 +73,6 @@ public boolean matches(String requirement) {
return range.getRecommendedVersion().compareTo(version) ==
0;
}
} catch (InvalidVersionSpecificationException ex) {
- // TODO error reporting
- ex.printStackTrace();
return false;
Review Comment:
I wish these classes were documented better, and I wish this one and several
others were non-public. That said, it does seem it's used in only one other
place where we do:
```
if (!matcher.matches(requirement.getValue())) {
getLog().debug("Toolchain " + this + " doesn't match
required property: " + key);
return false;
}
```
That is, a false result already logs at debug level.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
