[GitHub] [maven] MartinKanters commented on a diff in pull request #783: [MNG-7098] Keep the project counter intact when resuming a multi-module project.

[GitBox]

MartinKanters commented on code in PR #783:
URL: https://github.com/apache/maven/pull/783#discussion_r966788232


##########
maven-embedder/src/main/java/org/apache/maven/cli/event/ExecutionEventLogger.java:
##########
@@ -143,7 +143,11 @@ public void sessionStarted( ExecutionEvent event )
                         project.getName(), chars( ' ', ( len > 0 ) ? len : 1 
), project.getPackaging() );
             }
 
-            totalProjects = projects.size();
+            final List<MavenProject> allProjects = 
event.getSession().getAllProjects();

Review Comment:
   Yeah that's a good point. It's been there since 2014, though and the 
documentation of the member field shows exactly what we need :)
   
   ```
   /**
        * The full set of projects before any potential constraining by 
--projects. Useful in the case where you want to
        * build a smaller set of projects but perform other operations in the 
context of your reactor.
        */
   ```
   
   I'm inclined to keep it, what do you think? :) 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org