[GitHub] [maven] Giovds commented on a diff in pull request #783: [MNG-7098] Keep the project counter intact when resuming a multi-module project.

[GitBox]

Giovds commented on code in PR #783:
URL: https://github.com/apache/maven/pull/783#discussion_r966396162


##########
maven-embedder/src/main/java/org/apache/maven/cli/event/ExecutionEventLogger.java:
##########
@@ -143,7 +143,11 @@ public void sessionStarted( ExecutionEvent event )
                         project.getName(), chars( ' ', ( len > 0 ) ? len : 1 
), project.getPackaging() );
             }
 
-            totalProjects = projects.size();
+            final List<MavenProject> allProjects = 
event.getSession().getAllProjects();

Review Comment:
   Perhaps it might be worth noting that the `MavenSession#getAllProjects()` 
[states](https://github.com/apache/maven/blob/3c487fa697c3ff29d6c79ab5cf6e834abfd143b3/maven-core/src/main/java/org/apache/maven/execution/MavenSession.java#L273)
 `This is a provisional method and may be removed`. However long that may have 
been there :see_no_evil:.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org