[GitHub] [maven] Giovds commented on a diff in pull request #783: [MNG-7098] Keep the project counter intact when resuming a multi-module project.

[GitBox]

Giovds commented on code in PR #783:
URL: https://github.com/apache/maven/pull/783#discussion_r970407944


##########
maven-embedder/src/main/java/org/apache/maven/cli/event/ExecutionEventLogger.java:
##########
@@ -143,7 +143,11 @@ public void sessionStarted( ExecutionEvent event )
                         project.getName(), chars( ' ', ( len > 0 ) ? len : 1 
), project.getPackaging() );
             }
 
-            totalProjects = projects.size();
+            final List<MavenProject> allProjects = 
event.getSession().getAllProjects();

Review Comment:
   It makes sense to me to keep using this method. Perhaps the comment could be 
removed to avoid confusion as it is not annotated with `@Deprecated` and it is 
used in multiple places. I agree that these kind of "deprecation messages" are 
quite useless indeed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org