kwin commented on code in PR #144:
URL: https://github.com/apache/maven-scm/pull/144#discussion_r927551052
##########
maven-scm-providers/maven-scm-providers-git/maven-scm-provider-jgit/src/main/java/org/apache/maven/scm/provider/git/jgit/command/JGitUtils.java:
##########
@@ -576,8 +576,8 @@ public static List<ScmFile> removeAllFiles( Git git,
ScmFileSet fileSet )
// really tracked
for ( Iterator<File> itfl = fileSet.getFileList().iterator();
itfl.hasNext(); )
{
- String path = FilenameUtils.normalizeFilename( relativize(
baseUri, itfl.next() ) );
- if ( path.equals( FilenameUtils.normalizeFilename(
scmFile.getPath() ) ) )
+ String path = relativize( baseUri, itfl.next() );
+ if ( path.equals( scmFile.getPath() ) )
Review Comment:
this comparison is still wrong, IMHO you first need to make `itfl.next()`
absolute and then relativize against `workingCopyRootUri`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
