kwin commented on code in PR #144: URL: https://github.com/apache/maven-scm/pull/144#discussion_r927538093
########## maven-scm-providers/maven-scm-providers-git/maven-scm-provider-gittest/src/main/java/org/apache/maven/scm/provider/git/command/remove/GitRemoveCommandTckTest.java: ########## @@ -0,0 +1,85 @@ +package org.apache.maven.scm.provider.git.command.remove; + +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +import java.io.File; +import java.nio.charset.StandardCharsets; +import java.nio.file.Files; +import java.nio.file.StandardOpenOption; +import java.util.Arrays; + +import org.apache.maven.scm.ScmFileSet; +import org.apache.maven.scm.ScmTckTestCase; +import org.apache.maven.scm.command.remove.RemoveScmResult; +import org.apache.maven.scm.provider.git.GitScmTestUtils; + +/** + * This test tests the remove command. + * + * @author Georg Tsakumagos + */ +public abstract class GitRemoveCommandTckTest + extends ScmTckTestCase +{ + /** {@inheritDoc} */ + public void initRepo() + throws Exception + { + GitScmTestUtils.initRepo( "src/test/resources/repository/", getRepositoryRoot(), getWorkingDirectory() ); + } + + public void testCommandRemoveWithFile() + throws Exception + { + File toBeRemoved = new File( getWorkingDirectory().getAbsolutePath() + File.separator + "toto.xml" ); + + Files.write( toBeRemoved.getAbsoluteFile().toPath(), Review Comment: Right, then maybe simplify to ```suggestion Files.write( toBeRemoved.toPath(), Collections.singletonList("data"), StandardCharsets.ASCII, StandardOpenOption.CREATE ) ``` ########## maven-scm-providers/maven-scm-providers-git/maven-scm-provider-gittest/src/main/java/org/apache/maven/scm/provider/git/command/remove/GitRemoveCommandTckTest.java: ########## @@ -0,0 +1,85 @@ +package org.apache.maven.scm.provider.git.command.remove; + +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +import java.io.File; +import java.nio.charset.StandardCharsets; +import java.nio.file.Files; +import java.nio.file.StandardOpenOption; +import java.util.Arrays; + +import org.apache.maven.scm.ScmFileSet; +import org.apache.maven.scm.ScmTckTestCase; +import org.apache.maven.scm.command.remove.RemoveScmResult; +import org.apache.maven.scm.provider.git.GitScmTestUtils; + +/** + * This test tests the remove command. + * + * @author Georg Tsakumagos + */ +public abstract class GitRemoveCommandTckTest + extends ScmTckTestCase +{ + /** {@inheritDoc} */ + public void initRepo() + throws Exception + { + GitScmTestUtils.initRepo( "src/test/resources/repository/", getRepositoryRoot(), getWorkingDirectory() ); + } + + public void testCommandRemoveWithFile() + throws Exception + { + File toBeRemoved = new File( getWorkingDirectory().getAbsolutePath() + File.separator + "toto.xml" ); Review Comment: ```suggestion File toBeRemoved = new File( getWorkingDirectory(), "toto.xml" ); ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
