michael-o commented on code in PR #176:
URL:
https://github.com/apache/maven-integration-testing/pull/176#discussion_r905910857
##########
core-it-suite/src/test/java/org/apache/maven/it/IntegrationTestSuite.java:
##########
@@ -55,9 +56,9 @@ public static Test suite()
String executable = verifier.getExecutable();
- out.println( "Running integration tests for Maven " + mavenVersion
);
- out.println( "\tusing Maven executable: " + executable );
- out.println( "\twith verifier.forkMode: " + System.getProperty(
"verifier.forkMode", "not defined == fork" ) );
+ out.println( "Running integration tests for Maven " + mavenVersion
+ "\n"
Review Comment:
`System.lineSeparator()`
##########
core-it-support/core-it-plugins/pom.xml:
##########
@@ -121,7 +121,7 @@ under the License.
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-plugin-plugin</artifactId>
- <version>3.3</version>
+ <version>3.6.0</version>
Review Comment:
We are at 3.6.4 now.
##########
core-it-suite/src/test/java/org/apache/maven/it/MavenIT0146InstallerSnapshotNaming.java:
##########
@@ -108,6 +112,9 @@ public void testitRemoteDownloadTimestampedName()
}
+ @Test
+
+
public void testitNonTimestampedNameWithInstalledSNAPSHOT()
Review Comment:
Remove two empty lines
##########
pom.xml:
##########
@@ -136,7 +136,7 @@ under the License.
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-surefire-plugin</artifactId>
- <version>2.22.0</version>
+ <version>3.0.0-M6</version>
Review Comment:
M7?
##########
core-it-suite/src/test/java/org/apache/maven/it/IntegrationTestSuite.java:
##########
@@ -78,7 +79,7 @@ public static Test suite()
IOUtil.close( info );
}
- TestSuite suite = new TestSuite();
+ ClassOrderingData suite = new ClassOrderingData();
Review Comment:
What is the logical purpose of this new class?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
