michael-o commented on code in PR #176:
URL:
https://github.com/apache/maven-integration-testing/pull/176#discussion_r912731459
##########
core-it-suite/pom.xml:
##########
@@ -166,9 +162,10 @@ under the License.
<artifactId>maven-surefire-plugin</artifactId>
<configuration>
<includes>
- <include>**/IntegrationTestSuite.java</include>
+ <include>**/MavenIT*.java</include>
</includes>
- <forkMode>never</forkMode>
+ <forkCount>1</forkCount>
+ <reuseForks>true</reuseForks>
Review Comment:
Question: We have two profiles: `embedded` and none. Does this change the
behavior? Since non-embedded requires much more time.
##########
core-it-support/core-it-plugins/maven-it-plugin-class-loader/maven-it-plugin-class-loader/pom.xml:
##########
@@ -46,9 +46,9 @@ under the License.
<version>2.0</version>
</dependency>
<dependency>
- <groupId>junit</groupId>
- <artifactId>junit</artifactId>
- <version>3.8.2</version>
+ <groupId>org.junit.jupiter</groupId>
+ <artifactId>junit-jupiter</artifactId>
+ <version>5.8.0</version>
Review Comment:
Obviously this should be property, no?
##########
core-it-support/core-it-plugins/pom.xml:
##########
@@ -121,7 +121,7 @@ under the License.
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-plugin-plugin</artifactId>
- <version>3.3</version>
+ <version>3.6.0</version>
Review Comment:
Why two different version and not a single property?
##########
core-it-support/maven-it-plugin-bootstrap/pom.xml:
##########
@@ -57,6 +57,11 @@ under the License.
<artifactId>maven-resolver-impl</artifactId>
<version>${mavenResolverVersion}</version>
</dependency>
+ <dependency>
+ <groupId>org.apache.maven.plugin-tools</groupId>
+ <artifactId>maven-plugin-annotations</artifactId>
+ <version>3.3</version>
Review Comment:
3.6.4?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
