[ 
https://issues.apache.org/jira/browse/MRESOLVER-262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17551630#comment-17551630
 ] 

ASF GitHub Bot commented on MRESOLVER-262:
------------------------------------------

grgrzybek commented on PR #182:
URL: https://github.com/apache/maven-resolver/pull/182#issuecomment-1149914516

   So far, so good/great!
   I have Maven 3.8.6 using maven-resolver 1.8.1-SNAPSHOT with this PR merged 
and I'm running my tests.
   For example, for log4j 1.2.12, I have:
   ```
   log4j:log4j:jar:1.2.12 (compile) (plugin)
     org.apache.xbean:xbean-reflect:jar:3.4 (compile) (plugin)
       org.codehaus.plexus:plexus-container-default:jar:1.5.5 (compile) (plugin)
         org.apache.maven.plugins:maven-compiler-plugin:jar:3.1 () (plugin)
   ```
   
   And I could narrow down the extension to just one class - that extends 
`org.eclipse.aether.AbstractRepositoryListener` - so no more hacks of the 
resolver itself. And I can see everything I need in the data objects attached 
to available `org.eclipse.aether.RequestTrace`.
   
   Tomorrow I'll check how it affects the _embedded resolution process_ - 
because I have cases where separate resolution is performed within:
   * 
org.apache.camel.springboot:camel-spring-boot-generator-maven-plugin:prepare-spring-boot-starter
 mojo
   * org.apache.karaf.tooling:karaf-maven-plugin:assembly mojo
   
   I'll also provide some performance data.
   
   But for now I can say that this is a great addition to the resolver and 
exactly what I wanted ;).




> Provide contextual data in trace data for collector invoked requests
> --------------------------------------------------------------------
>
>                 Key: MRESOLVER-262
>                 URL: https://issues.apache.org/jira/browse/MRESOLVER-262
>             Project: Maven Resolver
>          Issue Type: Task
>          Components: Resolver
>            Reporter: Tamás Cservenák
>            Priority: Major
>             Fix For: 1.8.1
>
>
> During collection several RepositoryEvents are fired, but they does not carry 
> any context related data regarding artifact collection.
> Simplest solution would be to extend RequestTrace to provide:
>  * request context
>  * the artifact path (from root to leaf)
>  * leaf artifact being collected



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

Reply via email to