[
https://issues.apache.org/jira/browse/SCM-979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17540044#comment-17540044
]
ASF GitHub Bot commented on SCM-979:
------------------------------------
michael-o commented on code in PR #141:
URL: https://github.com/apache/maven-scm/pull/141#discussion_r877996117
##########
maven-scm-api/src/main/java/org/apache/maven/scm/log/Slf4jScmLogger.java:
##########
@@ -0,0 +1,195 @@
+package org.apache.maven.scm.log;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import static java.util.Objects.requireNonNull;
+
+/**
+ * {@link ScmLogger} backed by Slf4j.
+ *
+ * @since TBD
+ */
+public class Slf4jScmLogger
+ implements ScmLogger
+{
+ private final Logger logger;
+
+ public Slf4jScmLogger()
+ {
+ this( Slf4jScmLogger.class );
+ }
+
+ public Slf4jScmLogger( final Class<?> owner )
+ {
+ this( LoggerFactory.getLogger( owner ) );
Review Comment:
requirenonNull as well?
##########
pom.xml:
##########
@@ -182,20 +183,52 @@
<!
> Replace Plexus Container Default with Sisu Plexus Shim, Java8
> -------------------------------------------------------------
>
> Key: SCM-979
> URL: https://issues.apache.org/jira/browse/SCM-979
> Project: Maven SCM
> Issue Type: Task
> Reporter: Michael Osipov
> Assignee: Tamás Cservenák
> Priority: Major
> Fix For: 2.0.0-M2
>
>
> Changes:
> * make project Java8
> * update dependencies accordingly
> * remove any uses of deprecated Plexus APIs
> * replace plexus-container-default with plexus-shim
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
