slawekjaranowski commented on a change in pull request #484:
URL: https://github.com/apache/maven-surefire/pull/484#discussion_r820145350
##########
File path:
surefire-its/src/test/java/org/apache/maven/surefire/its/JUnitPlatformEnginesIT.java
##########
@@ -77,13 +77,14 @@
{
ArrayList<Object[]> args = new ArrayList<>();
args.add( new Object[] {"1.0.3", "5.0.3", "1.0.0", "1.0.0"} );
- args.add( new Object[] {"1.1.1", "5.1.1", "1.0.0", "1.0.0"} );
- args.add( new Object[] {"1.2.0", "5.2.0", "1.1.0", "1.0.0"} );
+ //args.add( new Object[] {"1.1.1", "5.1.1", "1.0.0", "1.0.0"} );
+ //args.add( new Object[] {"1.2.0", "5.2.0", "1.1.0", "1.0.0"} );
args.add( new Object[] {"1.3.2", "5.3.2", "1.1.1", "1.0.0"} );
- args.add( new Object[] {"1.4.2", "5.4.2", "1.1.1", "1.0.0"} );
- args.add( new Object[] {"1.5.2", "5.5.2", "1.2.0", "1.1.0"} );
+ //args.add( new Object[] {"1.4.2", "5.4.2", "1.1.1", "1.0.0"} );
+ //args.add( new Object[] {"1.5.2", "5.5.2", "1.2.0", "1.1.0"} );
args.add( new Object[] {"1.6.2", "5.6.2", "1.2.0", "1.1.0"} );
- //args.add( new Object[] { "1.6.0-SNAPSHOT", "5.6.0-SNAPSHOT",
"1.2.0", "1.1.0" } );
+ //args.add( new Object[] {"1.7.2", "5.7.2", "1.2.0", "1.1.0"} );
+ args.add( new Object[] {"1.8.2", "5.8.2", "1.2.0", "1.1.2"} );
Review comment:
Dead code should be removed ... or commented why and when we want to
restore it.
##########
File path: maven-surefire-plugin/src/site/apt/examples/junit-platform.apt.vm
##########
@@ -411,6 +411,53 @@ Using JUnit 5 Platform
</dependencies>
+---+
+** JUnit5 Suite
+
+ For more information see this
+
{{{https://github.com/apache/maven-surefire/tree/master/surefire-its/src/test/resources/junit5-suite}example}}.
+
++---+
+<dependencies>
+ <dependency>
+ <groupId>org.junit.jupiter</groupId>
+ <artifactId>junit-jupiter-api</artifactId>
+ <version>5.8.0</version>
+ <scope>test</scope>
+ </dependency>
+ <dependency>
+ <groupId>org.junit.platform</groupId>
+ <artifactId>junit-platform-suite-api</artifactId>
+ <version>1.8.0</version>
+ <scope>test</scope>
+ </dependency>
+</dependencies>
+<build>
+ <plugins>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-surefire-plugin</artifactId>
+ <configuration>
+ <includes>
+ <include>JUnit5Tests</include>
+ </includes>
+ </configuration>
+ <dependencies>
+ <dependency>
+ <groupId>org.junit.jupiter</groupId>
+ <artifactId>junit-jupiter-engine</artifactId>
+ <version>5.8.2</version>
+ </dependency>
+ <dependency>
+ <groupId>org.junit.platform</groupId>
+ <artifactId>junit-platform-suite-engine</artifactId>
+ <version>1.8.2</version>
+ </dependency>
+ </dependencies>
+ </plugin>
+ </plugins>
+</build>
Review comment:
Looks like next complicated ... why dependency in project and plugin
Even if we we support it in code for some reason we shouldn't give such
examples ... project dependency should be enough.
Maybe we should also link to JUnit documentation.
https://junit.org/junit5/docs/current/user-guide/#junit-platform-suite-engine
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
