Tibor17 commented on a change in pull request #484:
URL: https://github.com/apache/maven-surefire/pull/484#discussion_r820146776
##########
File path: maven-surefire-plugin/src/site/apt/examples/junit-platform.apt.vm
##########
@@ -411,6 +411,53 @@ Using JUnit 5 Platform
</dependencies>
+---+
+** JUnit5 Suite
+
+ For more information see this
+
{{{https://github.com/apache/maven-surefire/tree/master/surefire-its/src/test/resources/junit5-suite}example}}.
+
++---+
+<dependencies>
+ <dependency>
+ <groupId>org.junit.jupiter</groupId>
+ <artifactId>junit-jupiter-api</artifactId>
+ <version>5.8.0</version>
+ <scope>test</scope>
+ </dependency>
+ <dependency>
+ <groupId>org.junit.platform</groupId>
+ <artifactId>junit-platform-suite-api</artifactId>
+ <version>1.8.0</version>
+ <scope>test</scope>
+ </dependency>
+</dependencies>
+<build>
+ <plugins>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-surefire-plugin</artifactId>
+ <configuration>
+ <includes>
+ <include>JUnit5Tests</include>
+ </includes>
+ </configuration>
+ <dependencies>
+ <dependency>
+ <groupId>org.junit.jupiter</groupId>
+ <artifactId>junit-jupiter-engine</artifactId>
+ <version>5.8.2</version>
+ </dependency>
+ <dependency>
+ <groupId>org.junit.platform</groupId>
+ <artifactId>junit-platform-suite-engine</artifactId>
+ <version>1.8.2</version>
+ </dependency>
+ </dependencies>
+ </plugin>
+ </plugins>
+</build>
Review comment:
Because there are more alternatives. So the JUnit5 team separated API
from impl and they always stated that the user does not need to access the impl
of the engine.
If you like I put engines to the dependencies. Both would work. It's just
matter of taste.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
