Tibor17 commented on a change in pull request #333:
URL: https://github.com/apache/maven-surefire/pull/333#discussion_r568179480



##########
File path: 
maven-surefire-plugin/src/main/java/org/apache/maven/plugin/surefire/SurefirePlugin.java
##########
@@ -880,4 +900,20 @@ protected final ForkNodeFactory getForkNode()
     {
         return forkNode;
     }
+
+    @Override
+    boolean verifyParameters() throws MojoFailureException, 
MojoExecutionException
+    {
+        if ( failOnFlakeCount < 0 )

Review comment:
       As in my previous comment, this must be in the abstract class where are 
all the warning check method calls made in the section:
   ```
           else
           {
               ensureEnableProcessChecker();
               convertDeprecatedForkMode();
               ensureWorkingDirectoryExists();
               ensureParallelRunningCompatibility();
               ensureThreadCountWithPerThread();
               warnIfUselessUseSystemClassLoaderParameter();
               warnIfDefunctGroupsCombinations();
               warnIfRerunClashes();
               warnIfWrongShutdownValue();
               warnIfNotApplicableSkipAfterFailureCount();
               warnIfIllegalTempDir();
               warnIfForkCountIsZero();
               printDefaultSeedIfNecessary();
           }
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to