Tibor17 commented on a change in pull request #333: URL: https://github.com/apache/maven-surefire/pull/333#discussion_r568176510
########## File path: maven-surefire-plugin/src/main/java/org/apache/maven/plugin/surefire/SurefirePlugin.java ########## @@ -880,4 +900,20 @@ protected final ForkNodeFactory getForkNode() { return forkNode; } + + @Override + boolean verifyParameters() throws MojoFailureException, MojoExecutionException Review comment: This must not exist in both Plugin classes. See the super method in AbstractSurefireMojo and add a new warn* method and a call which finally calls the abstract method getFailOnFlakeCount. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org