Tibor17 commented on a change in pull request #333:
URL: https://github.com/apache/maven-surefire/pull/333#discussion_r568160462
##########
File path:
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/SurefireHelper.java
##########
@@ -286,7 +289,15 @@ private static String createErrorMessage(
SurefireReportParameters reportParamet
}
else
{
- msg.append( "There are test failures.\n\nPlease refer to " )
+ if ( result.getFailures() > 0 )
+ {
+ msg.append( "There are test failures." );
+ }
+ else
+ {
+ msg.append( "There are too many flakes." );
Review comment:
@oehme
I think this would not be printeted very often even if it could because
there is if-else.
We do not have IT test but both messages could be printed along. Why the
message `There are too many flakes.` does not have the concrete numbers. We
have both numbers available and they are the cause why the message is going to
be printed. I only want to give the user all reason why the plugin crashed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
