OlivierJaquemet commented on code in PR #16446:
URL: https://github.com/apache/lucene/pull/16446#discussion_r4094780330
##########
lucene/queryparser/src/test/org/apache/lucene/queryparser/flexible/standard/TestStandardQP.java:
##########
@@ -113,6 +115,51 @@ public TokenStreamComponents createComponents(String
fieldName) {
assertQueryEquals("a ! b", a, "a -b");
}
+ @Override
+ public void testRange() throws Exception {
Review Comment:
I had to create 2 protected methods, because the rewriting differs:
- in `testRange` : part of query gets wrapped in parentheses `(...)`
- in `testSimpleDAO `: par of query gets wrapped in plus sign and
parentheses `+(...)`
I'm not entirely sure it makes the whole test more easier to maintain, but
it's better than my initial approach of duplicating the whole method !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
