OlivierJaquemet commented on PR #16446: URL: https://github.com/apache/lucene/pull/16446#issuecomment-5524292102
Just to make sure I understand the actions you’re suggesting: * integrate the unit tests from #16442 into this PR, so that both issues are addressed in a single change * update the initial fix in this PR to use the `addClause` approach, based on your commit * include the modified resources required by the regeneration process * fix the cosmetic changes required in the other unit tests I would also add: * update the changelog with references to both issues and credit you as well And then, perhaps: * close #16442, with a note that this PR addresses the issue and that PR #16442 is no longer required * ask for a new review of this PR on the dev mailing list? If that sounds good to you, I’ll take care of it as soon as possible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
