romseygeek commented on code in PR #16515:
URL: https://github.com/apache/lucene/pull/16515#discussion_r3948593952
##########
lucene/core/src/test/org/apache/lucene/search/TestMaxScoreBulkScorer.java:
##########
@@ -1446,6 +1482,14 @@ public float getMaxScore(int upTo) throws IOException {
minGetMaxScoreUpTo[0] = Math.min(minGetMaxScoreUpTo[0],
upTo);
return in.getMaxScore(upTo);
}
+
+ @Override
+ public void nextDocsAndScores(
+ int upTo, Bits liveDocs, DocAndFloatFeatureBuffer buffer)
throws IOException {
+ in.nextDocsAndScores(upTo, liveDocs, buffer);
+ scoredDocs[0] += buffer.size;
+ nextDocsAndScoresCalls[0]++;
Review Comment:
Thinking again, I think we can stay with just checking that scoredDocs and
collectedDocs are equal, ie we haven't scored any doc that was then rejected by
the filter - no need to check the state of liveDocs directly.
Can we also delete some docs (some that match the filter, some that don't)
to ensure that the masking is working properly?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
