romseygeek commented on code in PR #16515:
URL: https://github.com/apache/lucene/pull/16515#discussion_r3922964570
##########
lucene/core/src/java/org/apache/lucene/search/MaxScoreBulkScorer.java:
##########
@@ -50,6 +50,7 @@ final class MaxScoreBulkScorer extends BulkScorer {
private final FixedBitSet windowMatches = new FixedBitSet(INNER_WINDOW_SIZE);
private final double[] windowScores = new double[INNER_WINDOW_SIZE];
private FixedBitSet filterMatches = null;
Review Comment:
I think we can remove `filterMatches` entirely now and use
`filterMatchesBits.bits` instead?
##########
lucene/core/src/test/org/apache/lucene/search/TestMaxScoreBulkScorer.java:
##########
@@ -1216,7 +1217,10 @@ public void testDenseScorersUseBitSet() throws
IOException {
public void setScorer(Scorable scorer) {}
@Override
- public void collect(int doc) {}
+ public void collect(int doc) {
+ assertEquals(1, doc % 20);
Review Comment:
This would pass without your changes I think? We want to be checking that
we're not scoring filtered documents - maybe we can wrap the Scorer and check
the output of `nextDocsAndScores()`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
