romseygeek commented on PR #16629: URL: https://github.com/apache/lucene/pull/16629#issuecomment-5538000491
Catching up here... is the issue that the min and max values as stored in Points don't necessarily translate to the actual min and max double values? I think we need to check that that we aren't making this assumption in other places as well, eg looking at IndexSortSortedNumericDocValuesRangeQuery we use `IntPoint.pack()` and `LongPoint.pack()`? +1 to reverting the change to SortedNumericDocValuesRangeQuery, but I think NumericFieldStats is worth keeping. We need to update it though to take a decoding parameter, and add a bunch more tests. In general I think we don't have enough tests for non-integral numeric values. I can pick that up. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
