xabbu42 commented on PR #16489: URL: https://github.com/apache/lucene/pull/16489#issuecomment-5392563944
> I'm not sure how I missed the factory change, sorry! No worries. Thanks for taking the time to review my pull request! > As for the old constructor, this is a public method in a public class, and it's not marked @lucene.experimental, so we cannot remove it without a major release. I dropped the commits removing the old constructor. So now this pull request adds an additional new constructor with the documentation mostly copied, as the AI originally did it. I hope this is the correct way to document multiple constructors? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
