xabbu42 commented on PR #16489: URL: https://github.com/apache/lucene/pull/16489#issuecomment-5358809678
1. I actually removed the backwards-compatible constructor assuming that this is something internal. I can put it back. Should I copy-paste the documentation of the common arguments to both constructors? 2. I did add handling of an ignoreKeywords flag to PatternReplaceFilterFactory, is anything else needed? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
