msokolov commented on PR #16489: URL: https://github.com/apache/lucene/pull/16489#issuecomment-5356255393
This seems reasonable, but: 1. should we have a backwards-compatible constructor that does not require the new flag? 2. I think PatternReplaceFilterFactory would also need to be updated -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
