uschindler commented on PR #15823: URL: https://github.com/apache/lucene/pull/15823#issuecomment-4142353273
I agree. Ideally the code should be like: do the fast addall until you hit exception. Once you hit it in foreach call, clean up the heap with down heap and then add the remaining elements "the slow" way. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
