gsmiller commented on PR #15823: URL: https://github.com/apache/lucene/pull/15823#issuecomment-4135359827
> Anyways, if the size is not required to optimize any allocation then lets go with the above ideas! I'll also add my +1 to not adding all the new iteration-related code. My personal preference would be for the new addAll method to take a Stream as input instead of directly accepting a filtering function. Let the caller create the stream with filtering logic (or whatever they need) then just consume the stream in addAll. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
