vsop-479 commented on PR #15823:
URL: https://github.com/apache/lucene/pull/15823#issuecomment-4150165859

   I think there is a difference between add and addAll, with add the caller 
can use the element to compare to PQ’s top and maybe pop the top and reAdd the 
element after got an AIOOBE(maybe the normal usage is judge wether the queue is 
full firstly?), but if we want addAll behave the same after AIOOBE, we need 
keep remaining elements in the stream, so the caller can add them 
intersect(maybe stream already works like this? I will verify it)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to