Pulkitg64 commented on code in PR #15476:
URL: https://github.com/apache/lucene/pull/15476#discussion_r2605612807
##########
lucene/backward-codecs/src/test/org/apache/lucene/backward_codecs/lucene102/TestLucene102BinaryQuantizedVectorsFormat.java:
##########
@@ -186,4 +186,9 @@ public void testQuantizedVectorsWriteAndRead() throws
IOException {
}
}
}
+
+ @Override
+ protected boolean supportsFloatVectorFallback() {
Review Comment:
> we want new formats to have to explicitly think about this question
Yes that's right :) and If any new test class implements the function and
returns true, then the test case will fail with empty float vector error. This
would trigger the user to implement fallback in the codec.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
