Pulkitg64 commented on code in PR #15470:
URL: https://github.com/apache/lucene/pull/15470#discussion_r2592204937
##########
lucene/core/src/java/org/apache/lucene/util/hnsw/InitializedHnswGraphBuilder.java:
##########
@@ -441,7 +441,7 @@ private void addConnections(int node, int targetLevel,
UpdateableRandomVectorSco
popToScratch(candidates, scratchArray);
// Add diverse neighbors and establish bidirectional connections
- addDiverseNeighbors(targetLevel, node, scratchArray, scorer, true);
Review Comment:
Yes, that's a good idea. Let me check the recall with these changes.
> Did you commit any changes to thatin support of the testing?
No, not yet. Will try to raise PR for adding deletes support in knnPerfTest
in some time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]