msokolov commented on code in PR #15470:
URL: https://github.com/apache/lucene/pull/15470#discussion_r2589193893


##########
lucene/core/src/java/org/apache/lucene/util/hnsw/InitializedHnswGraphBuilder.java:
##########
@@ -441,7 +441,7 @@ private void addConnections(int node, int targetLevel, 
UpdateableRandomVectorSco
     popToScratch(candidates, scratchArray);
 
     // Add diverse neighbors and establish bidirectional connections
-    addDiverseNeighbors(targetLevel, node, scratchArray, scorer, true);

Review Comment:
   oops, I'll add this back!  I wonder if we should do at least a quick test to 
make sure this change isn't harming recall too much in the heavy deletion case, 
but I'm unsure how you ran the tests.  I guess it was with luceneutil?  Did you 
commit any changes to thatin support of the testing?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to