msokolov commented on code in PR #15294:
URL: https://github.com/apache/lucene/pull/15294#discussion_r2461013848
##########
lucene/core/src/test/org/apache/lucene/internal/vectorization/TestVectorizationProvider.java:
##########
@@ -24,6 +24,10 @@ public void testCallerOfGetter() {
expectThrows(UnsupportedOperationException.class,
TestVectorizationProvider::illegalCaller);
}
+ public void testGetProviderName() {
+ assertEquals("DefaultVectorizationProvider",
VectorizationProvider.getImplementationName());
Review Comment:
Yes, the value that gets used will currently either be
`DefaultVectorizationProvider` or `PanamaVectorizationProvider` - The Panama
one gets used when the JDK is new enough and the CPU preferred vector size can
handle it ... the logic is in `VectorizationProvider`. So this test will pass
or fail depending on the host and JDK used to run it. Although since we require
JDK version in the build I think that will be guaranteed to support. But we
probably would need to add some kind of `assumeTrue` so the test doesn't fail
on architectures that do or don't support the level of Panama we require.
I'm actually surprised this test passed for you and on github - I would have
expected the result to be `PanamaVectorizationProvider` for most setups?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
