msokolov commented on code in PR #15294:
URL: https://github.com/apache/lucene/pull/15294#discussion_r2411638661
##########
lucene/core/src/test/org/apache/lucene/internal/vectorization/TestVectorizationProvider.java:
##########
@@ -24,6 +24,10 @@ public void testCallerOfGetter() {
expectThrows(UnsupportedOperationException.class,
TestVectorizationProvider::illegalCaller);
}
+ public void testGetProviderName() {
+ assertEquals("DefaultVectorizationProvider",
VectorizationProvider.getImplementationName());
Review Comment:
This is all makes sense to me, but I'm wondering under what circumstances we
would have an alternate provider and whether we can test that. Is that
something that only happens in the MRJAR code? If that's right, do we have
MRJAR-specific tests where we could test that this also works when we have a
non-default provider?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
