tflobbe commented on code in PR #15294:
URL: https://github.com/apache/lucene/pull/15294#discussion_r2461063635
##########
lucene/core/src/test/org/apache/lucene/internal/vectorization/TestVectorizationProvider.java:
##########
@@ -24,6 +24,10 @@ public void testCallerOfGetter() {
expectThrows(UnsupportedOperationException.class,
TestVectorizationProvider::illegalCaller);
}
+ public void testGetProviderName() {
+ assertEquals("DefaultVectorizationProvider",
VectorizationProvider.getImplementationName());
Review Comment:
> But we probably would need to add some kind of assumeTrue
ah, yes, that's a good idea
> I'm actually surprised this test passed for you and on github - I would
have expected the result to be PanamaVectorizationProvider for most setups?
I guess the build system isn't adding the incubator vectorization module?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
