uschindler commented on PR #15104: URL: https://github.com/apache/lucene/pull/15104#issuecomment-3214804799
Hi, I pushed changes to fix also test framework still using the old `long[]` for testing multi-segment index inputs and close working correctly. Actually like with the benachmark those tests were no longer testing the new implementation. I added `@Deprecated` to all `GroupVIntUtil` that use `long[]` and moved them to the end of the class. The Methods used for the optimization was completely removed. One thing I did not fix: I added `Deprecated` also to the DataOutput method. We should remove that completely in main (see new issue by @jpountz). In 10.x we' cant remove it yet because there may be code that has implemented it in custom DataOutputs. Actually the method should not be in DataOutput at all and the whole thing should be completely handled by the util class. (that's my personal opinion). What's strange: Badwards codecs is stil able to write, so the writing code was not removed, otherwise the writeGroupVInt with longs could have been removed completely. @jpountz: Can you have a quick look? I will merge this otherwise in a moment (and backport) to proceed with refactoring an allowing to give the VarHandles/Lambda a second try. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
