HUSTERGS commented on PR #15081:
URL: https://github.com/apache/lucene/pull/15081#issuecomment-3209014331
Since both @jpountz and my last benchmark results showed a slowdown on
Combined tasks, I did a micro benchmark locally (not commit with this pr) and
change the way `copyWithMinDocRequired` works. It seems the related tasks no
longer suffered from this change. Although I still don't know why this speedup
cannot be reproduced on other machines : (
```
TaskQPS baseline StdDevQPS
my_modified_version StdDev Pct diff p-value
Prefix3 71.47 (13.1%) 64.90
(17.1%) -9.2% ( -34% - 24%) 0.056
FilteredPrefix3 66.61 (12.3%) 60.87
(16.3%) -8.6% ( -33% - 22%) 0.059
Wildcard 45.67 (5.0%) 44.48
(7.1%) -2.6% ( -14% - 10%) 0.179
TermTitleSort 51.37 (4.3%) 50.39
(3.6%) -1.9% ( -9% - 6%) 0.127
CombinedOrHighHigh 5.50 (3.3%) 5.43
(4.4%) -1.3% ( -8% - 6%) 0.275
CountPhrase 2.63 (4.4%) 2.60
(4.5%) -1.1% ( -9% - 8%) 0.440
SpanNear 2.45 (5.7%) 2.44
(4.9%) -0.7% ( -10% - 10%) 0.664
CombinedAndHighHigh 5.64 (1.6%) 5.60
(1.5%) -0.7% ( -3% - 2%) 0.147
CombinedOrHighMed 19.30 (5.6%) 19.19
(6.3%) -0.6% ( -11% - 11%) 0.756
FilteredAndStopWords 8.27 (2.6%) 8.23
(2.7%) -0.5% ( -5% - 4%) 0.532
IntervalsOrdered 2.42 (3.9%) 2.41
(4.6%) -0.5% ( -8% - 8%) 0.695
FilteredPhrase 9.41 (3.4%) 9.36
(3.0%) -0.5% ( -6% - 6%) 0.615
Phrase 7.39 (3.0%) 7.36
(3.2%) -0.4% ( -6% - 6%) 0.657
CombinedTerm 10.97 (4.8%) 10.92
(4.7%) -0.4% ( -9% - 9%) 0.782
FilteredAndHighHigh 10.28 (2.5%) 10.24
(3.1%) -0.4% ( -5% - 5%) 0.673
CountAndHighMed 71.02 (2.3%) 70.84
(3.3%) -0.3% ( -5% - 5%) 0.773
AndHighOrMedMed 13.59 (3.1%) 13.56
(2.9%) -0.2% ( -5% - 5%) 0.813
TermMonthSort 2027.04 (2.4%) 2022.76
(2.8%) -0.2% ( -5% - 5%) 0.798
FilteredOrMany 3.87 (3.1%) 3.86
(3.7%) -0.2% ( -6% - 6%) 0.876
CombinedAndHighMed 19.70 (5.4%) 19.67
(5.2%) -0.1% ( -10% - 11%) 0.931
CountFilteredOrHighMed 17.78 (0.6%) 17.77
(0.8%) -0.0% ( -1% - 1%) 0.858
Respell 34.74 (3.5%) 34.73
(3.9%) -0.0% ( -7% - 7%) 0.977
FilteredOrStopWords 7.84 (2.8%) 7.84
(2.1%) -0.0% ( -4% - 4%) 0.995
CountFilteredOrHighHigh 15.70 (0.8%) 15.70
(1.0%) 0.0% ( -1% - 1%) 0.995
CountAndHighHigh 48.12 (1.6%) 48.13
(1.9%) 0.0% ( -3% - 3%) 0.959
CountOrHighMed 71.81 (2.1%) 71.86
(2.6%) 0.1% ( -4% - 4%) 0.933
SloppyPhrase 1.10 (3.8%) 1.10
(4.3%) 0.1% ( -7% - 8%) 0.941
FilteredAnd3Terms 99.65 (3.0%) 99.79
(4.2%) 0.1% ( -6% - 7%) 0.899
FilteredOrHighHigh 12.32 (3.0%) 12.34
(3.0%) 0.2% ( -5% - 6%) 0.843
CountFilteredPhrase 8.59 (4.8%) 8.60
(3.7%) 0.2% ( -7% - 9%) 0.889
CountFilteredIntNRQ 16.31 (1.2%) 16.35
(1.2%) 0.2% ( -2% - 2%) 0.584
TermDTSort 137.28 (3.4%) 137.57
(3.6%) 0.2% ( -6% - 7%) 0.852
FilteredOr3Terms 40.96 (3.9%) 41.05
(4.5%) 0.2% ( -7% - 9%) 0.876
FilteredTerm 60.63 (3.0%) 60.76
(3.1%) 0.2% ( -5% - 6%) 0.818
FilteredOrHighMed 36.01 (4.1%) 36.09
(4.6%) 0.2% ( -8% - 9%) 0.867
TermDayOfYearSort 251.59 (1.9%) 252.18
(2.3%) 0.2% ( -3% - 4%) 0.727
CountFilteredOrMany 4.26 (2.9%) 4.27
(3.1%) 0.3% ( -5% - 6%) 0.790
FilteredOr2Terms2StopWords 45.71 (5.0%) 45.84
(5.6%) 0.3% ( -9% - 11%) 0.870
Fuzzy2 34.01 (3.8%) 34.11
(3.8%) 0.3% ( -7% - 8%) 0.798
IntNRQ 42.39 (3.2%) 42.54
(3.0%) 0.4% ( -5% - 6%) 0.718
CountOrMany 4.76 (2.9%) 4.79
(3.5%) 0.4% ( -5% - 7%) 0.662
CountOrHighHigh 48.94 (2.0%) 49.19
(2.2%) 0.5% ( -3% - 4%) 0.454
DismaxOrHighMed 45.32 (7.5%) 45.57
(5.7%) 0.6% ( -11% - 14%) 0.789
FilteredIntNRQ 41.96 (3.1%) 42.22
(3.1%) 0.6% ( -5% - 7%) 0.518
CountTerm 5386.09 (3.1%) 5421.82
(2.2%) 0.7% ( -4% - 6%) 0.436
OrMany 4.18 (5.8%) 4.21
(4.5%) 0.7% ( -9% - 11%) 0.655
DismaxTerm 464.76 (4.1%) 468.41
(2.7%) 0.8% ( -5% - 7%) 0.471
Fuzzy1 37.46 (4.4%) 37.81
(4.4%) 0.9% ( -7% - 10%) 0.502
FilteredAndHighMed 30.45 (2.6%) 30.73
(3.2%) 1.0% ( -4% - 6%) 0.305
IntSet 286.66 (3.7%) 289.69
(4.0%) 1.1% ( -6% - 9%) 0.385
Term1M 430.69 (5.6%) 437.59
(3.4%) 1.6% ( -7% - 11%) 0.274
TermB1M1P 430.98 (5.5%) 438.19
(3.6%) 1.7% ( -6% - 11%) 0.252
Term100 431.18 (5.4%) 438.44
(3.6%) 1.7% ( -6% - 11%) 0.244
TermB1M 430.94 (5.4%) 438.20
(3.5%) 1.7% ( -6% - 11%) 0.245
Term 431.05 (5.5%) 438.47
(3.5%) 1.7% ( -6% - 11%) 0.240
Term10K 430.57 (5.4%) 438.14
(3.6%) 1.8% ( -6% - 11%) 0.227
OrHighRare 90.01 (6.8%) 91.85
(6.0%) 2.1% ( -10% - 15%) 0.312
DismaxOrHighHigh 33.24 (4.7%) 34.11
(4.9%) 2.6% ( -6% - 12%) 0.083
FilteredAnd2Terms2StopWords 55.60 (5.1%) 57.06
(5.8%) 2.6% ( -7% - 14%) 0.127
And2Terms2StopWords 52.76 (7.4%) 54.44
(7.6%) 3.2% ( -10% - 19%) 0.179
Or2Terms2StopWords 53.71 (8.4%) 55.44
(7.6%) 3.2% ( -11% - 21%) 0.206
And3Terms 67.49 (4.3%) 70.15
(5.3%) 3.9% ( -5% - 14%) 0.010
OrStopWords 9.03 (6.1%) 9.41
(7.1%) 4.2% ( -8% - 18%) 0.045
Or3Terms 60.45 (8.4%) 62.99
(7.9%) 4.2% ( -11% - 22%) 0.104
OrHighMed 61.26 (9.7%) 64.00
(8.9%) 4.5% ( -12% - 25%) 0.128
AndStopWords 8.40 (2.1%) 8.83
(2.7%) 5.2% ( 0% - 10%) 0.000
AndHighMed 51.02 (3.3%) 53.74
(4.2%) 5.3% ( -2% - 13%) 0.000
OrHighHigh 21.02 (7.4%) 22.18
(8.9%) 5.5% ( -10% - 23%) 0.033
AndMedOrHighHigh 14.97 (2.5%) 15.93
(2.6%) 6.4% ( 1% - 11%) 0.000
AndHighHigh 21.94 (2.2%) 23.42
(3.1%) 6.7% ( 1% - 12%) 0.000
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
