jpountz commented on PR #15081: URL: https://github.com/apache/lucene/pull/15081#issuecomment-3197302709
I ran this PR on my machine, it seems to trigger a small slowdown on combined tasks (p-value is low) and it's not clear if there's any speedup: ``` TaskQPS baseline StdDevQPS my_modified_version StdDev Pct diff p-value CombinedOrHighHigh 21.80 (3.2%) 21.30 (2.7%) -2.3% ( -8% - 3%) 0.014 CombinedOrHighMed 82.43 (3.3%) 80.56 (2.7%) -2.3% ( -7% - 3%) 0.017 CombinedTerm 37.39 (1.9%) 37.01 (1.6%) -1.0% ( -4% - 2%) 0.071 CountPhrase 4.18 (2.3%) 4.14 (3.1%) -0.8% ( -6% - 4%) 0.349 CountFilteredOrMany 26.87 (1.8%) 26.66 (1.8%) -0.8% ( -4% - 2%) 0.178 CombinedAndHighMed 85.34 (0.9%) 84.68 (0.7%) -0.8% ( -2% - 0%) 0.004 CombinedAndHighHigh 22.41 (1.0%) 22.26 (0.8%) -0.7% ( -2% - 1%) 0.018 CountAndHighHigh 355.09 (2.4%) 353.53 (1.8%) -0.4% ( -4% - 3%) 0.505 CountFilteredOrHighHigh 135.69 (1.0%) 135.19 (0.9%) -0.4% ( -2% - 1%) 0.230 AndHighOrMedMed 48.73 (2.2%) 48.56 (1.4%) -0.4% ( -3% - 3%) 0.524 CountFilteredOrHighMed 147.59 (0.7%) 147.08 (0.6%) -0.3% ( -1% - 1%) 0.106 TermDayOfYearSort 285.69 (1.3%) 284.77 (1.9%) -0.3% ( -3% - 2%) 0.536 FilteredTerm 153.91 (2.3%) 153.47 (2.2%) -0.3% ( -4% - 4%) 0.688 FilteredIntNRQ 298.60 (0.9%) 297.83 (0.7%) -0.3% ( -1% - 1%) 0.286 CountOrHighHigh 335.61 (2.8%) 334.77 (1.8%) -0.3% ( -4% - 4%) 0.736 FilteredAndStopWords 64.09 (1.7%) 64.00 (1.2%) -0.1% ( -3% - 2%) 0.757 CountOrMany 28.56 (2.1%) 28.54 (1.2%) -0.1% ( -3% - 3%) 0.856 FilteredOr3Terms 161.75 (1.0%) 161.69 (1.1%) -0.0% ( -2% - 2%) 0.911 FilteredPhrase 31.15 (1.4%) 31.14 (1.7%) -0.0% ( -3% - 3%) 0.966 FilteredOr2Terms2StopWords 142.53 (1.2%) 142.54 (1.2%) 0.0% ( -2% - 2%) 0.983 CountOrHighMed 342.17 (1.8%) 342.40 (1.6%) 0.1% ( -3% - 3%) 0.897 FilteredOrHighMed 148.34 (1.1%) 148.45 (1.0%) 0.1% ( -1% - 2%) 0.814 CountTerm 8770.53 (3.1%) 8777.75 (3.2%) 0.1% ( -6% - 6%) 0.934 FilteredOrMany 15.86 (1.9%) 15.88 (1.6%) 0.1% ( -3% - 3%) 0.827 FilteredAnd2Terms2StopWords 212.24 (1.5%) 212.54 (1.2%) 0.1% ( -2% - 2%) 0.746 CountAndHighMed 298.80 (1.2%) 299.23 (0.9%) 0.1% ( -1% - 2%) 0.677 FilteredAndHighHigh 77.57 (1.7%) 77.68 (1.2%) 0.2% ( -2% - 3%) 0.748 CountFilteredPhrase 24.92 (1.6%) 24.97 (1.8%) 0.2% ( -3% - 3%) 0.693 TermMonthSort 3305.82 (2.0%) 3313.86 (2.0%) 0.2% ( -3% - 4%) 0.702 FilteredOrStopWords 43.63 (3.0%) 43.78 (2.1%) 0.4% ( -4% - 5%) 0.666 FilteredAnd3Terms 184.72 (2.7%) 185.50 (2.2%) 0.4% ( -4% - 5%) 0.593 FilteredOrHighHigh 64.39 (2.5%) 64.67 (1.9%) 0.4% ( -3% - 4%) 0.533 FilteredAndHighMed 151.49 (3.8%) 152.26 (2.9%) 0.5% ( -6% - 7%) 0.639 TermDTSort 381.66 (2.4%) 383.70 (2.7%) 0.5% ( -4% - 5%) 0.508 FilteredPrefix3 149.35 (2.6%) 150.35 (2.6%) 0.7% ( -4% - 6%) 0.415 Or3Terms 219.76 (8.4%) 221.28 (6.4%) 0.7% ( -13% - 16%) 0.769 Or2Terms2StopWords 194.85 (6.9%) 196.43 (5.4%) 0.8% ( -10% - 14%) 0.682 AndMedOrHighHigh 80.68 (5.6%) 81.38 (4.1%) 0.9% ( -8% - 11%) 0.578 TermTitleSort 83.74 (3.6%) 84.58 (3.3%) 1.0% ( -5% - 8%) 0.355 And3Terms 229.24 (8.1%) 231.68 (6.6%) 1.1% ( -12% - 17%) 0.649 And2Terms2StopWords 195.53 (6.3%) 197.67 (5.6%) 1.1% ( -10% - 13%) 0.559 OrStopWords 45.72 (11.2%) 46.22 (8.5%) 1.1% ( -16% - 23%) 0.727 OrHighMed 239.52 (9.7%) 242.30 (7.5%) 1.2% ( -14% - 20%) 0.672 OrHighHigh 72.35 (12.7%) 73.23 (9.7%) 1.2% ( -18% - 26%) 0.733 OrMany 22.17 (4.0%) 22.47 (3.5%) 1.3% ( -5% - 9%) 0.268 AndHighMed 189.15 (11.6%) 192.00 (9.6%) 1.5% ( -17% - 25%) 0.653 AndStopWords 44.46 (10.2%) 45.14 (8.4%) 1.5% ( -15% - 22%) 0.607 Term 614.05 (9.7%) 623.36 (7.9%) 1.5% ( -14% - 21%) 0.589 AndHighHigh 64.25 (12.8%) 65.24 (10.5%) 1.5% ( -19% - 28%) 0.678 OrHighRare 272.53 (11.1%) 277.09 (9.7%) 1.7% ( -17% - 25%) 0.612 ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org