HUSTERGS commented on PR #15081:
URL: https://github.com/apache/lucene/pull/15081#issuecomment-3193969629

   Since I'm  little bit confused by the cause of performance gain, I re-run 
the util to double-check it, here is the second benchmark result:
   ```
                               TaskQPS baseline      StdDevQPS 
my_modified_version      StdDev                Pct diff p-value
                         OrHighRare       91.58      (5.4%)       90.35      
(7.9%)   -1.3% ( -13% -   12%) 0.527
                            Prefix3       74.58      (3.6%)       73.61      
(4.8%)   -1.3% (  -9% -    7%) 0.336
                        CountPhrase        2.66      (2.1%)        2.62      
(3.9%)   -1.3% (  -7% -    4%) 0.188
                    FilteredPrefix3       69.51      (3.4%)       68.76      
(4.6%)   -1.1% (  -8% -    7%) 0.400
                          TermB1M1P      397.72      (6.2%)      395.01      
(6.7%)   -0.7% ( -12% -   13%) 0.738
                               Term      397.58      (6.1%)      395.33      
(6.8%)   -0.6% ( -12% -   13%) 0.782
                            Term100      397.36      (6.1%)      395.17      
(6.8%)   -0.6% ( -12% -   13%) 0.787
                            Term10K      397.53      (6.2%)      395.35      
(6.7%)   -0.5% ( -12% -   13%) 0.787
                       CombinedTerm       10.82      (3.5%)       10.77      
(4.1%)   -0.4% (  -7% -    7%) 0.721
                   IntervalsOrdered        2.44      (2.6%)        2.43      
(3.6%)   -0.4% (  -6% -    5%) 0.676
                             Term1M      397.47      (6.0%)      395.92      
(7.0%)   -0.4% ( -12% -   13%) 0.850
                            TermB1M      397.18      (6.1%)      395.64      
(6.9%)   -0.4% ( -12% -   13%) 0.850
                 CombinedOrHighHigh        5.49      (3.5%)        5.47      
(3.7%)   -0.4% (  -7% -    7%) 0.737
                        CountOrMany        4.80      (3.4%)        4.79      
(3.2%)   -0.4% (  -6% -    6%) 0.740
                      TermTitleSort       51.38      (4.2%)       51.22      
(4.6%)   -0.3% (  -8% -    8%) 0.827
                           SpanNear        2.46      (5.0%)        2.45      
(6.1%)   -0.3% ( -10% -   11%) 0.867
                   CountAndHighHigh       48.08      (2.1%)       48.00      
(1.9%)   -0.2% (  -4% -    3%) 0.769
                    CountOrHighHigh       49.17      (2.6%)       49.09      
(2.3%)   -0.2% (  -4% -    4%) 0.817
                CountFilteredOrMany        4.28      (2.8%)        4.27      
(2.9%)   -0.2% (  -5% -    5%) 0.845
                           Wildcard       46.51      (2.1%)       46.46      
(3.1%)   -0.1% (  -5% -    5%) 0.910
               FilteredAndStopWords        8.22      (2.2%)        8.22      
(3.0%)   -0.0% (  -5% -    5%) 0.970
            CountFilteredOrHighHigh       15.76      (0.8%)       15.76      
(0.9%)   -0.0% (  -1% -    1%) 0.996
             CountFilteredOrHighMed       17.84      (0.7%)       17.85      
(0.8%)    0.0% (  -1% -    1%) 0.920
                FilteredOrStopWords        7.85      (2.3%)        7.85      
(3.0%)    0.0% (  -5% -    5%) 0.967
                     CountOrHighMed       71.51      (2.1%)       71.55      
(2.2%)    0.1% (  -4% -    4%) 0.935
                CombinedAndHighHigh        5.61      (1.3%)        5.61      
(1.6%)    0.1% (  -2% -    2%) 0.899
                    CountAndHighMed       70.68      (2.8%)       70.75      
(2.6%)    0.1% (  -5% -    5%) 0.906
                       SloppyPhrase        1.11      (3.8%)        1.11      
(4.0%)    0.1% (  -7% -    8%) 0.920
                FilteredAndHighHigh       10.22      (2.4%)       10.23      
(3.3%)    0.1% (  -5% -    6%) 0.886
                             Phrase        7.39      (2.2%)        7.40      
(2.3%)    0.2% (  -4% -    4%) 0.772
                     FilteredOrMany        3.86      (3.4%)        3.87      
(3.4%)    0.2% (  -6% -    7%) 0.830
                CountFilteredIntNRQ       16.33      (1.2%)       16.37      
(1.1%)    0.2% (  -2% -    2%) 0.516
                             IntNRQ       42.56      (2.7%)       42.66      
(2.7%)    0.2% (  -5% -    5%) 0.776
                         DismaxTerm      448.07      (4.6%)      449.36      
(3.8%)    0.3% (  -7% -    9%) 0.828
                  TermDayOfYearSort      252.26      (2.2%)      253.08      
(1.4%)    0.3% (  -3% -    4%) 0.577
                  CombinedOrHighMed       19.30      (5.5%)       19.37      
(5.9%)    0.3% ( -10% -   12%) 0.846
                     FilteredIntNRQ       42.16      (2.7%)       42.31      
(2.6%)    0.4% (  -4% -    5%) 0.656
                CountFilteredPhrase        8.58      (3.4%)        8.61      
(3.8%)    0.4% (  -6% -    7%) 0.728
                 FilteredOrHighHigh       12.35      (2.9%)       12.40      
(3.3%)    0.4% (  -5% -    6%) 0.684
                             OrMany        4.06      (6.2%)        4.08      
(6.6%)    0.4% ( -11% -   14%) 0.838
                    AndHighOrMedMed       13.49      (2.7%)       13.56      
(3.0%)    0.5% (  -5% -    6%) 0.593
                   FilteredOr3Terms       41.01      (4.2%)       41.22      
(4.4%)    0.5% (  -7% -    9%) 0.713
                             Fuzzy2       33.72      (4.4%)       33.89      
(5.0%)    0.5% (  -8% -   10%) 0.734
                          CountTerm     5519.28      (2.6%)     5547.79      
(2.1%)    0.5% (  -4% -    5%) 0.491
                       FilteredTerm       60.30      (2.3%)       60.63      
(3.4%)    0.6% (  -5% -    6%) 0.544
                             IntSet      286.83      (3.3%)      288.51      
(4.0%)    0.6% (  -6% -    8%) 0.611
                  FilteredOrHighMed       36.14      (4.2%)       36.36      
(4.6%)    0.6% (  -7% -    9%) 0.657
                            Respell       34.65      (3.8%)       34.87      
(4.0%)    0.6% (  -6% -    8%) 0.610
         FilteredOr2Terms2StopWords       45.74      (5.2%)       46.05      
(5.4%)    0.7% (  -9% -   11%) 0.692
                             Fuzzy1       37.23      (5.0%)       37.48      
(5.1%)    0.7% (  -8% -   11%) 0.673
                 CombinedAndHighMed       19.64      (4.8%)       19.77      
(5.3%)    0.7% (  -8% -   11%) 0.671
                         TermDTSort      136.72      (3.4%)      137.70      
(3.5%)    0.7% (  -5% -    7%) 0.511
                  FilteredAnd3Terms       99.36      (3.7%)      100.18      
(3.6%)    0.8% (  -6% -    8%) 0.475
                      TermMonthSort     2067.37      (2.0%)     2085.00      
(1.8%)    0.9% (  -2% -    4%) 0.161
                     FilteredPhrase        9.33      (2.8%)        9.43      
(3.5%)    1.0% (  -5% -    7%) 0.308
                    DismaxOrHighMed       44.36      (6.9%)       44.81      
(4.6%)    1.0% (  -9% -   13%) 0.577
                   AndMedOrHighHigh       15.36      (4.2%)       15.54      
(3.3%)    1.1% (  -6% -    9%) 0.353
                 FilteredAndHighMed       30.00      (4.0%)       30.46      
(3.2%)    1.5% (  -5% -    9%) 0.183
        FilteredAnd2Terms2StopWords       54.75      (6.0%)       55.79      
(5.3%)    1.9% (  -8% -   13%) 0.286
                And2Terms2StopWords       51.39      (8.7%)       52.87      
(6.9%)    2.9% ( -11% -   20%) 0.248
                       AndStopWords        8.16      (6.3%)        8.40      
(1.8%)    2.9% (  -4% -   11%) 0.046
                 Or2Terms2StopWords       51.97      (7.9%)       53.69      
(6.8%)    3.3% ( -10% -   19%) 0.155
                          And3Terms       65.09      (8.6%)       67.50      
(4.4%)    3.7% (  -8% -   18%) 0.087
                   DismaxOrHighHigh       31.54      (4.9%)       32.74      
(4.4%)    3.8% (  -5% -   13%) 0.010
                        OrStopWords        8.08      (6.5%)        8.41      
(3.7%)    4.1% (  -5% -   15%) 0.015
                           Or3Terms       57.13      (8.6%)       59.89      
(5.1%)    4.8% (  -8% -   20%) 0.031
                         AndHighMed       47.53      (9.3%)       49.88      
(3.2%)    4.9% (  -6% -   19%) 0.024
                          OrHighMed       56.33      (9.6%)       59.54      
(5.3%)    5.7% (  -8% -   22%) 0.020
                        AndHighHigh       19.41      (8.9%)       20.76      
(2.4%)    7.0% (  -3% -   19%) 0.001
                         OrHighHigh       17.52      (8.1%)       18.91      
(4.5%)    7.9% (  -4% -   22%) 0.000
   ```
   
   I suspect that pre-filter doc can help because it reduces some useless 
advance of some clauses, since they now have some kind of global view (docs 
filtered by `maxOtherDoc`), so the `applyRequiredClause` always makes some true 
progress. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to