aylonsk commented on code in PR #14932:
URL: https://github.com/apache/lucene/pull/14932#discussion_r2248956741


##########
lucene/backward-codecs/src/test/org/apache/lucene/backward_codecs/lucene99/Lucene99HnswVectorsFormatV0.java:
##########
@@ -0,0 +1,233 @@
+/*

Review Comment:
   I added a test-only constructor to the format class, eliminating the need 
for the "V0" testing files. However, this also required me to make a similar 
type of constructor in the writer class. If these changes feel excessive, 
@kaivalnp showed me a way to keep the version logic out of the format class and 
specify the writer version separately when initializing. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to