kaivalnp commented on code in PR #14932:
URL: https://github.com/apache/lucene/pull/14932#discussion_r2255078770
##########
lucene/core/src/java/org/apache/lucene/codecs/lucene99/Lucene99HnswVectorsWriter.java:
##########
@@ -88,11 +90,24 @@ public Lucene99HnswVectorsWriter(
int numMergeWorkers,
TaskExecutor mergeExec)
throws IOException {
+ this(state, M, beamWidth, flatVectorWriter, numMergeWorkers, mergeExec, 1);
Review Comment:
Sorry I missed this earlier -- this should be `VERSION_CURRENT` instead of
`1`
##########
lucene/core/src/java/org/apache/lucene/codecs/lucene99/Lucene99HnswVectorsWriter.java:
##########
@@ -88,11 +90,24 @@ public Lucene99HnswVectorsWriter(
int numMergeWorkers,
TaskExecutor mergeExec)
throws IOException {
+ this(state, M, beamWidth, flatVectorWriter, numMergeWorkers, mergeExec, 1);
+ }
+
+ Lucene99HnswVectorsWriter(
Review Comment:
Maybe add a "test-only" comment here too?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
