msokolov commented on code in PR #14932:
URL: https://github.com/apache/lucene/pull/14932#discussion_r2246453620
##########
lucene/core/src/java/org/apache/lucene/codecs/lucene99/Lucene99HnswVectorsFormat.java:
##########
@@ -212,7 +213,7 @@ public KnnVectorsReader fieldsReader(SegmentReadState
state) throws IOException
@Override
public int getMaxDimensions(String fieldName) {
- return 1024;
+ return 4096;
Review Comment:
we probably don't want to make this change? At least not as part of this PR
:)
##########
lucene/core/src/java/org/apache/lucene/codecs/lucene99/Lucene99HnswVectorsReader.java:
##########
@@ -76,6 +79,7 @@ public final class Lucene99HnswVectorsReader extends
KnnVectorsReader
private final FieldInfos fieldInfos;
private final IntObjectHashMap<FieldEntry> fields;
private final IndexInput vectorIndex;
+ private final Populator dataReader;
Review Comment:
I think `dataReader` will confuse people since that is the name of a class
(`DataReader`). Maybe call it `decoder`? Or `neighborDecoder`?
##########
lucene/backward-codecs/src/test/org/apache/lucene/backward_codecs/lucene99/Lucene99HnswVectorsFormatV0.java:
##########
@@ -0,0 +1,233 @@
+/*
Review Comment:
So I think we are introducing these backward_codecs in order to be able to
write graphs in the old VInt (v0) format in order to test that we are able to
read them back with the existing codec?
Given that, I think any additional classes we add here could live in the
tests rather than in backward_codecs, since we won't need these for reading old
indexes (which is what backward_codecs are for).
Having said that, I wonder if we could add a test-only constructor to the
format that would enable it to continue writing the old format?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
