jpountz commented on PR #14932: URL: https://github.com/apache/lucene/pull/14932#issuecomment-3087240130
@aylonsk To handle backward compatibility, I'd recommend doing the following: - Add a new version constant to the format class, something like `VERSION_GROUP_VARINT = 1; VERSION_CURRENT = VERSION_GROUP_VARINT`. - Add a `int version` parameter to a pkg-private constructor of this format. - Pass this version to the writer, write it in the codec header, and update the writer to use group varint when version >= 1, and vint otherwise. - Make the reader read the version from the codec header, use group varint when version >= 1, and vint otherwise. - Copy `TestLucene99HnswVectorsFormat` into a new test case that exercises version=VERSION_START. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org