uschindler commented on code in PR #14910: URL: https://github.com/apache/lucene/pull/14910#discussion_r2213980484
########## lucene/core/src/java/org/apache/lucene/internal/vectorization/VectorizationProvider.java: ########## @@ -114,6 +114,8 @@ public static VectorizationProvider getInstance() { /** Create a new {@link PostingDecodingUtil} for the given {@link IndexInput}. */ public abstract PostingDecodingUtil newPostingDecodingUtil(IndexInput input) throws IOException; + public abstract BitSetUtil newBitSetUtil(); Review Comment: I agree with this. It is stateless so let's reuse the already existing method. Then we can also have the "if Constant" part there. You can ignore my other note. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org