uschindler commented on code in PR #14910:
URL: https://github.com/apache/lucene/pull/14910#discussion_r2213601617
##########
lucene/benchmark-jmh/src/java/org/apache/lucene/benchmark/jmh/BitsetToArrayBenchmark.java:
##########
@@ -361,6 +390,94 @@ private static int _denseBranchLessParallel(long word,
int[] resultArray, int of
return hOffset;
}
+ private static final byte[] IDENTITY_BYTES = new byte[64];
+
+ static {
+ for (int i = 0; i < IDENTITY_BYTES.length; i++) {
+ IDENTITY_BYTES[i] = (byte) i;
+ }
+ }
+
+ // NOCOMMIT remove vectorized methods and requirement on vector module
before merge.
Review Comment:
Ah, yes this needs to go away. Our build system found this already. ❤️
##########
lucene/benchmark-jmh/src/java/module-info.java:
##########
@@ -25,6 +25,7 @@
requires org.apache.lucene.core;
requires org.apache.lucene.expressions;
requires org.apache.lucene.sandbox;
+ requires jdk.incubator.vector;
Review Comment:
Please remove the code from benchmark module and only benchmark code in the
java24 source set.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
