jpountz commented on PR #14910: URL: https://github.com/apache/lucene/pull/14910#issuecomment-3084743355
FWIW I benchmarked this change on my machine (AVX2), there may be a small speedup for some queries but not as much as previously reported: ``` TaskQPS baseline StdDevQPS my_modified_version StdDev Pct diff p-value FilteredDismaxTerm 159.75 (1.8%) 156.59 (2.0%) -2.0% ( -5% - 1%) 0.020 FilteredTerm 160.05 (1.8%) 157.28 (2.4%) -1.7% ( -5% - 2%) 0.064 FilteredPhrase 31.66 (1.9%) 31.21 (2.4%) -1.4% ( -5% - 2%) 0.144 FilteredDismaxOrHighHigh 69.26 (2.1%) 68.44 (3.1%) -1.2% ( -6% - 4%) 0.324 Term 624.66 (6.6%) 617.30 (4.6%) -1.2% ( -11% - 10%) 0.644 FilteredAnd2Terms2StopWords 211.38 (1.5%) 209.23 (1.9%) -1.0% ( -4% - 2%) 0.194 CountTerm 9064.76 (1.7%) 8973.82 (3.5%) -1.0% ( -6% - 4%) 0.413 FilteredAnd3Terms 187.39 (1.3%) 185.79 (1.3%) -0.9% ( -3% - 1%) 0.142 CombinedOrHighHigh 22.75 (1.0%) 22.56 (1.6%) -0.8% ( -3% - 1%) 0.154 And2Terms2StopWords 199.52 (1.9%) 197.87 (2.5%) -0.8% ( -5% - 3%) 0.397 AndHighOrMedMed 49.74 (1.6%) 49.33 (1.9%) -0.8% ( -4% - 2%) 0.296 CountFilteredPhrase 24.76 (2.0%) 24.57 (2.9%) -0.8% ( -5% - 4%) 0.487 AndMedOrHighHigh 85.96 (1.2%) 85.32 (2.4%) -0.8% ( -4% - 2%) 0.383 And3Terms 235.75 (1.9%) 234.03 (2.1%) -0.7% ( -4% - 3%) 0.410 Or2Terms2StopWords 200.01 (2.5%) 198.59 (3.1%) -0.7% ( -6% - 5%) 0.572 FilteredIntNRQ 289.06 (0.8%) 287.05 (1.7%) -0.7% ( -3% - 1%) 0.251 FilteredDismaxOrHighMed 125.35 (1.9%) 124.53 (2.3%) -0.7% ( -4% - 3%) 0.486 FilteredOrHighHigh 65.45 (2.9%) 65.04 (2.0%) -0.6% ( -5% - 4%) 0.572 CombinedTerm 37.78 (1.8%) 37.56 (2.1%) -0.6% ( -4% - 3%) 0.499 FilteredAndHighMed 153.64 (1.7%) 152.75 (2.0%) -0.6% ( -4% - 3%) 0.489 CombinedAndHighHigh 22.87 (1.0%) 22.75 (1.9%) -0.6% ( -3% - 2%) 0.412 TermDTSort 408.86 (3.1%) 406.81 (4.9%) -0.5% ( -8% - 7%) 0.783 FilteredOr2Terms2StopWords 143.31 (2.1%) 142.59 (1.7%) -0.5% ( -4% - 3%) 0.551 FilteredOrHighMed 149.58 (1.9%) 148.84 (1.3%) -0.5% ( -3% - 2%) 0.488 OrMany 22.71 (2.2%) 22.60 (2.4%) -0.5% ( -4% - 4%) 0.627 CombinedAndHighMed 87.88 (0.7%) 87.45 (1.1%) -0.5% ( -2% - 1%) 0.232 OrHighRare 273.20 (12.1%) 272.03 (11.1%) -0.4% ( -21% - 25%) 0.934 FilteredOr3Terms 162.88 (1.8%) 162.22 (1.2%) -0.4% ( -3% - 2%) 0.545 CombinedOrHighMed 86.79 (0.6%) 86.45 (1.2%) -0.4% ( -2% - 1%) 0.352 FilteredAndStopWords 64.14 (2.8%) 63.95 (3.8%) -0.3% ( -6% - 6%) 0.844 FilteredOrMany 15.94 (2.8%) 15.90 (1.5%) -0.3% ( -4% - 4%) 0.779 Or3Terms 226.68 (2.3%) 226.18 (2.8%) -0.2% ( -5% - 4%) 0.846 CountOrHighMed 359.27 (2.3%) 358.53 (2.1%) -0.2% ( -4% - 4%) 0.834 DismaxOrHighMed 184.76 (2.7%) 184.40 (2.1%) -0.2% ( -4% - 4%) 0.853 DismaxTerm 730.52 (2.8%) 729.16 (2.1%) -0.2% ( -5% - 4%) 0.868 FilteredPrefix3 147.61 (1.7%) 147.38 (2.9%) -0.2% ( -4% - 4%) 0.883 CountAndHighMed 305.37 (1.3%) 305.04 (1.4%) -0.1% ( -2% - 2%) 0.859 OrHighMed 251.29 (3.0%) 251.10 (3.0%) -0.1% ( -5% - 6%) 0.955 AndHighMed 197.92 (2.3%) 197.86 (2.3%) -0.0% ( -4% - 4%) 0.975 TermDayOfYearSort 270.57 (6.3%) 270.54 (6.1%) -0.0% ( -11% - 13%) 0.996 FilteredOrStopWords 43.96 (3.1%) 43.98 (2.6%) 0.0% ( -5% - 5%) 0.978 CountPhrase 4.06 (2.8%) 4.06 (2.1%) 0.1% ( -4% - 5%) 0.946 FilteredAndHighHigh 77.63 (2.8%) 77.74 (3.0%) 0.1% ( -5% - 6%) 0.918 CountFilteredOrHighMed 146.93 (0.7%) 147.31 (0.6%) 0.3% ( -1% - 1%) 0.370 CountOrMany 28.14 (1.4%) 28.23 (1.2%) 0.3% ( -2% - 2%) 0.613 DismaxOrHighHigh 126.24 (5.6%) 126.71 (4.8%) 0.4% ( -9% - 11%) 0.874 CountFilteredOrHighHigh 135.00 (1.0%) 135.57 (0.7%) 0.4% ( -1% - 2%) 0.276 CountFilteredOrMany 26.38 (1.7%) 26.54 (1.5%) 0.6% ( -2% - 3%) 0.397 CountOrHighHigh 332.56 (2.5%) 336.29 (2.4%) 1.1% ( -3% - 6%) 0.307 CountAndHighHigh 349.06 (2.2%) 353.95 (2.1%) 1.4% ( -2% - 5%) 0.149 OrHighHigh 76.02 (3.4%) 77.64 (3.1%) 2.1% ( -4% - 9%) 0.149 OrStopWords 47.26 (3.3%) 48.31 (3.7%) 2.2% ( -4% - 9%) 0.162 AndStopWords 45.69 (2.5%) 46.71 (3.0%) 2.2% ( -3% - 7%) 0.071 AndHighHigh 67.01 (2.5%) 69.40 (3.2%) 3.6% ( -2% - 9%) 0.005 ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org