rmuir commented on code in PR #14901:
URL: https://github.com/apache/lucene/pull/14901#discussion_r2190391854
##########
lucene/core/src/java/org/apache/lucene/internal/vectorization/VectorizationProvider.java:
##########
@@ -63,16 +62,6 @@ public abstract class VectorizationProvider {
// ignored
}
TESTS_VECTOR_SIZE = vs;
-
- boolean enforce = false;
Review Comment:
it is already tested, you hit the same condition by passing vector size 128.
I think the trap is just the way we randomize, you need to run the tests a
couple times to exercise all the cases? Apparently we got "lucky" (or unlucky
depending on how you see it) here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
