uschindler commented on code in PR #14901:
URL: https://github.com/apache/lucene/pull/14901#discussion_r2190379968
##########
lucene/core/src/java/org/apache/lucene/internal/vectorization/VectorizationProvider.java:
##########
@@ -63,16 +62,6 @@ public abstract class VectorizationProvider {
// ignored
}
TESTS_VECTOR_SIZE = vs;
-
- boolean enforce = false;
Review Comment:
I would keep this in, because it allows us to still test correctness of the
integer and float vectors. The TestVeczorUtil test enforces a fixed bitsize to
test all variants of our code (also the slow ones on the test-runner CPU).
As we no bail out completely if we have no fast integer vectors, we no
longer test it on all CPUs.
So we should keep the boolean or alternatively use
`TESTS_VECTOR_SIZE.isPresent()` to check for test mode like:
```java
TESTS_FORCE_INTEGER_VECTORS = TESTS_VECTOR_SIZE.isPresent();
```
The complete removal of any testing is not a good idea.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
