rmuir commented on code in PR #14901:
URL: https://github.com/apache/lucene/pull/14901#discussion_r2190385477
##########
lucene/core/src/java24/org/apache/lucene/internal/vectorization/PanamaVectorConstants.java:
##########
@@ -42,8 +42,7 @@ final class PanamaVectorConstants {
// to be fair, they do document this thing only works well with AVX2/AVX3
and Neon
boolean isAMD64withoutAVX2 =
Constants.OS_ARCH.equals("amd64") && PREFERRED_VECTOR_BITSIZE < 256;
- HAS_FAST_INTEGER_VECTORS =
- VectorizationProvider.TESTS_FORCE_INTEGER_VECTORS ||
(isAMD64withoutAVX2 == false);
+ HAS_FAST_INTEGER_VECTORS = isAMD64withoutAVX2 == false;
Review Comment:
if we can better contain this constant we can also give it a better name.
The idea is: if you are on x86, you need AVX2 as a minimum baseline for us to
support vectors.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
