dsmiley commented on code in PR #14764:
URL: https://github.com/apache/lucene/pull/14764#discussion_r2143110804
##########
build-tools/build-infra/src/main/groovy/lucene.datasets.external-datasets.gradle:
##########
@@ -162,29 +167,31 @@ configure(project(":lucene:benchmark")) {
logger.lifecycle("Extracting ${ext.name} into ${ext.dst}...")
ext.dst.deleteDir()
- buildinfra.extractReuters(untarPath.toString(), ext.dst.toString())
+ ExtractReuters.main(untarPath.toString(), ext.dst.toString())
}
- }
-
- task downloadDatasets() {
- group "Data set download"
- description "Download all data sets."
- }
-
- [
- getEnWiki,
- getGeoNames,
- getTop100kWikiWordFiles,
- getReuters,
- getEnWikiRandomLines
- ].each { task ->
- task.group "Data set download"
- task.description "Download the ${task.ext.name} data set."
-
- downloadDatasets.dependsOn(task)
-
- task.doFirst {
- logger.lifecycle("Downloading data set ${task.ext.name} from
${task.ext.src} to ${task.ext.dst}...")
+ })
+
+ def downloadTasks = [
+ getEnWikiTask,
+ getGeoNamesTask,
+ getTop100kWikiWordFilesTask,
+ getReutersTask,
+ getEnWikiRandomLinesTask
+ ]
+
+ tasks.register("downloadDatasets", {
+ group = "Data set download"
+ description = "Download all data sets."
+
+ dependsOn downloadTasks
+ })
+
+ downloadTasks.each {
+ it.configure {
+ group = "Data set download"
+ doFirst {
Review Comment:
What are "the new gradle conventions" that you speak of? I wish I was aware
of whatever the conventions should be since in my experience there are too many
styles and I don't know which to prefer or when not to.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
